I'm inclined to agree with you about the charges. Not about the favours. I think Trump was smart enough to be able to not have his name attached to any fraudulent documents, so he might avoid prosecution.
I read on another site that what could potentially happen is Weissberg could be forced to testify. Under the Trump Organizations employment agreements, they will cover legal expenses. However, some see this could be construed as bribery to not testify against the Trumps. The idea being that if Weissberg had to pay out of his own pocket to defend himself, he would probably couldn't afford it for long, and would be more willing to accept a plea and testify. So, the prosecution could have the court waive this expense, since it could obstruct justice.
Just look at what happened to Michael Cohen. His legal bills were covered until he flipped on Trump, and he faced a stiff legal bill.
Regardless, I do not think this is political retribution. I mean, not directly. A lot of serious allegations about fraud and tax evasion came out of solid reporting during Trump's term. You can't blame a DA from seeing a potential case and launching an investigation. I mean, if they let it stand, than that would be seen as if Trump and his crew were above the law.
Now, all that being said, who can say how successful they will be in making charges stick.